-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[all] Update to TypeScript v5.7.2, remove "suppressImplicitAnyIndexErrors" rule #3885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
busma13
force-pushed
the
typescript-implicit-any-index-errors
branch
from
January 2, 2025 22:14
2a3938b
to
1f5335a
Compare
busma13
changed the title
WIP remove "suppressImplicitAnyIndexErrors: true" from all package tsconfigs
WIP Update TypeScript, remove "suppressImplicitAnyIndexErrors" rule
Jan 3, 2025
busma13
changed the title
WIP Update TypeScript, remove "suppressImplicitAnyIndexErrors" rule
[all] Update TypeScript, remove "suppressImplicitAnyIndexErrors" rule
Jan 6, 2025
jsnoble
reviewed
Jan 6, 2025
jsnoble
reviewed
Jan 6, 2025
jsnoble
reviewed
Jan 6, 2025
packages/teraslice/src/lib/cluster/services/cluster/backends/kubernetesV2/index.ts
Outdated
Show resolved
Hide resolved
jsnoble
reviewed
Jan 6, 2025
packages/teraslice/src/lib/cluster/services/cluster/backends/kubernetesV2/k8sState.ts
Show resolved
Hide resolved
jsnoble
reviewed
Jan 6, 2025
packages/teraslice/src/lib/cluster/services/cluster/backends/native/messaging.ts
Outdated
Show resolved
Hide resolved
jsnoble
reviewed
Jan 6, 2025
busma13
changed the title
[all] Update TypeScript, remove "suppressImplicitAnyIndexErrors" rule
[all] Update to TypeScript v5.7.2, remove "suppressImplicitAnyIndexErrors" rule
Jan 6, 2025
jsnoble
requested changes
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some simple changes
busma13
force-pushed
the
typescript-implicit-any-index-errors
branch
from
January 7, 2025 15:36
f3a4aef
to
31124c0
Compare
bump: (minor) @terascope/[email protected], [email protected] bump: (minor) [email protected], [email protected] bump: (minor) @terascope/[email protected], @terascope/[email protected] bump: (minor) @terascope/[email protected], @terascope/[email protected] bump: (minor) [email protected], [email protected] bump: (minor) @terascope/[email protected], @terascope/[email protected]
busma13
force-pushed
the
typescript-implicit-any-index-errors
branch
from
January 7, 2025 15:45
31124c0
to
16c9a08
Compare
busma13
commented
Jan 7, 2025
jsnoble
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
typescript
from v5.2.2 to v5.7.2suppressExplicitAnyIndexErrors
rule from alltsconfig.json
files@types/gc-stats
v1.4.3 dev dependencyref: #3772