Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[all] Update to TypeScript v5.7.2, remove "suppressImplicitAnyIndexErrors" rule #3885

Merged
merged 21 commits into from
Jan 7, 2025

Conversation

busma13
Copy link
Contributor

@busma13 busma13 commented Dec 18, 2024

This PR makes the following changes:

  • Update typescript from v5.2.2 to v5.7.2
  • remove suppressExplicitAnyIndexErrors rule from all tsconfig.json files
  • fix all typescript errors associated with removing the above rule
  • add missing @types/gc-stats v1.4.3 dev dependency
  • bump teraslice to v2.11.0

ref: #3772

@busma13 busma13 force-pushed the typescript-implicit-any-index-errors branch from 2a3938b to 1f5335a Compare January 2, 2025 22:14
@busma13 busma13 changed the title WIP remove "suppressImplicitAnyIndexErrors: true" from all package tsconfigs WIP Update TypeScript, remove "suppressImplicitAnyIndexErrors" rule Jan 3, 2025
@busma13 busma13 changed the title WIP Update TypeScript, remove "suppressImplicitAnyIndexErrors" rule [all] Update TypeScript, remove "suppressImplicitAnyIndexErrors" rule Jan 6, 2025
@busma13 busma13 marked this pull request as ready for review January 6, 2025 15:09
@busma13 busma13 requested a review from jsnoble January 6, 2025 15:25
@busma13 busma13 changed the title [all] Update TypeScript, remove "suppressImplicitAnyIndexErrors" rule [all] Update to TypeScript v5.7.2, remove "suppressImplicitAnyIndexErrors" rule Jan 6, 2025
Copy link
Member

@jsnoble jsnoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some simple changes

@busma13 busma13 force-pushed the typescript-implicit-any-index-errors branch from f3a4aef to 31124c0 Compare January 7, 2025 15:36
@busma13 busma13 force-pushed the typescript-implicit-any-index-errors branch from 31124c0 to 16c9a08 Compare January 7, 2025 15:45
Copy link
Member

@jsnoble jsnoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnoble jsnoble merged commit 87939ad into master Jan 7, 2025
46 checks passed
@jsnoble jsnoble deleted the typescript-implicit-any-index-errors branch January 7, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants